New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// java.lang.NumberFormatException: Invalid int: "" #131

Closed
ape-report opened this Issue Mar 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ape-report

ape-report commented Mar 7, 2018

Port does not check empty input. parseInt should be used carefully.

// java.lang.NumberFormatException: Invalid int: ""
//  at java.lang.Integer.invalidInt(Integer.java:138)
//  at java.lang.Integer.parseInt(Integer.java:358)
//  at java.lang.Integer.parseInt(Integer.java:334)
//  at org.primftpd.prefs.PortEditTextPreference.onPreferenceChange(PortEditTextPreference.java:31)
//  at android.preference.Preference.callChangeListener(Preference.java:939)
//  at android.preference.EditTextPreference.onDialogClosed(EditTextPreference.java:145)
//  at android.preference.DialogPreference.onDismiss(DialogPreference.java:395)
//  at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1323)
//  at android.os.Handler.dispatchMessage(Handler.java:102)
//  at android.os.Looper.loop(Looper.java:148)
//  at android.app.ActivityThread.main(ActivityThread.java:5417)
//  at java.lang.reflect.Method.invoke(Native Method)
//  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
//  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

@wolpi wolpi added this to the 5.7 milestone Mar 9, 2018

@wolpi

This comment has been minimized.

Owner

wolpi commented Mar 9, 2018

Oh, yes. Beginner mistake 😇

@wolpi

This comment has been minimized.

Owner

wolpi commented Mar 9, 2018

should be fixed now

@wolpi wolpi closed this Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment