Add OPCache reporter #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Opcache stats to the logger.
dz0ny
force-pushed
the
add/opcache-stats
branch
from
519c74e
to
b767ca8
Compare
am-on
reviewed
Apr 11, 2019
dz0ny
force-pushed
the
add/opcache-stats
branch
from
f530010
to
5bc4dd4
Compare
am-on
reviewed
Apr 11, 2019
| continue; | ||
| } | ||
| // left trim so it becomes `plugin-slug/{index.php, ...}` | ||
| $plugin_base = substr( $script, $plugins_base_length, $plugins_base_length ); |
There was a problem hiding this comment.
Suggested change
| $plugin_base = substr( $script, $plugins_base_length, $plugins_base_length ); | |
| $plugin_base = substr( "wp-content/plugins/super-long-plugin-name-123456789/...", 19, 19 ); | |
| // "super-long-plugin-na" |
I'm wondering if this can happen because you use $plugins_base_length as substring length
There was a problem hiding this comment.
Ah no, because both WP_PLUGINS_PATH (and the reason for wp_normalize) and opcache have absolute paths. If one, for example, uses chroot, then both paths would be again based on the same folder structure.
am-on
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export Opcache stats to logger.
ref: https://github.com/niteoweb/woocart/issues/738