Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Tap gesture issue on ios/android devices #1033

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

andreek commented Feb 25, 2014

I've had an issue with a tap gesture on mobile devices (android and iOS). The gesture doesn't trigger the slider to show next items. The slider even doesn't work with others gestures after the first try to make a tap.

After some research I've found that the Slider was locked into the event.preventDefault part in onTouchStart-Listener, because slider.animating was set to true, but there was no running animation.

function onTouchStart(e) {
  if (slider.animating) {
    e.preventDefault();
  } else if ( ( window.navigator.msPointerEnabled ) || e.touches.length === 1 ) {
  .....
  }
}

So I've forced in the onTouchEnd-Listener to set slider.animating to false and it solves the problem. I don't know if this is an enhancement in general.The behaviour of the slider didn't broke with this solution.

Contributor

tylerxo commented Jun 26, 2014

This issue was fixed with this commit:

f0e9b4c

@tylerxo tylerxo closed this Jun 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment