New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Issue 245 - Variable Image Width #1157

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@loayza

loayza commented Jul 10, 2014

This is an improved reattempt of this other pull request.

I realised that the mentioned request got stucked due a merge conflict that was never resolved and it was apparently abandoned by the author.

What I've done is to fork the current version, to resolve the conflict and to rebase onto the latest version.

I've tried to contact the author of the original request before creating this new request, but I've received no reply from him.

Nevertheless, I suppose that he would be happy if his code is finally added to the plug-in :-)

@wells

This comment has been minimized.

Show comment
Hide comment
@wells

wells Jan 28, 2015

@loayza I hope this does get committed.

wells commented Jan 28, 2015

@loayza I hope this does get committed.

@zanematthew

This comment has been minimized.

Show comment
Hide comment
@zanematthew

zanematthew Mar 27, 2015

@loayza @wells I noticed this one also has issues, in that it doesn't advance the slider forward when used in thumbs. Here's a working example of the default slider with thumbs http://flexslider.woothemes.com/thumbnail-slider.html

Granted this will untouched/noticed for several more months.

zanematthew commented Mar 27, 2015

@loayza @wells I noticed this one also has issues, in that it doesn't advance the slider forward when used in thumbs. Here's a working example of the default slider with thumbs http://flexslider.woothemes.com/thumbnail-slider.html

Granted this will untouched/noticed for several more months.

@jeffikus jeffikus self-assigned this Mar 31, 2015

variableImageWidth: function() {
var minHeight = 0;
slider.newSlides.each(function(index) {
$(this).children('img').first().height('auto');

This comment has been minimized.

@jsit

jsit Apr 16, 2015

Contributor

Why only use img elements to determine slide height? What if a slide has no img element?

@jsit

jsit Apr 16, 2015

Contributor

Why only use img elements to determine slide height? What if a slide has no img element?

@jsit

This comment has been minimized.

Show comment
Hide comment
@jsit

jsit Apr 16, 2015

Contributor

Should this setting be named something else? Not all slides will necessarily be images; some may be just text, or an image with a caption, or a YouTube embed, etc.

Contributor

jsit commented Apr 16, 2015

Should this setting be named something else? Not all slides will necessarily be images; some may be just text, or an image with a caption, or a YouTube embed, etc.

if(imgWidth === 0 || imgWidth === null) imgWidth = slider.computedW;
if(index == current) slider.currentWidth = imgWidth;
if(index < start) startWidth += imgWidth;
if(index < offset) offsetWidth += imgWidth;

This comment has been minimized.

@jentscke

jentscke May 8, 2015

Here you should additionally sum slider.vars.itemMargin to get itemMargin working correctly

@jentscke

jentscke May 8, 2015

Here you should additionally sum slider.vars.itemMargin to get itemMargin working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment