Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added setOption public method to support dynamic min/max demo #648

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

RwwL commented Apr 24, 2013

Although this repo doesn't currently contain a dynamic min/max demo page, the http://flexslider.woothemes.com/ site still does include that example, and it's broken (watch the console for JS errors when resizing the window, the page tries to modify flexslider.vars, which doesn't exist — vars is not a public property on the plugin instance).

This pull request:

  • adds a simple public setOption method to flexsider
  • uses that method to to reintroduce the dynamic min/max demo and get the demo working
  • updates the nav on all the demo pages to include the dynamic min/max demo
  • fixes minor spelling/formatting bugs
Owner

mattyza commented Apr 24, 2013

Please see the "develop" branch where the min/max logic is in place and working correctly. :)

Thanks for your pull request! :)

Contributor

RwwL commented Apr 24, 2013

D'oh, sorry I wasted the time (both of ours). When do you typically merge develop into master and do official releases?

Contributor

RwwL commented Apr 24, 2013

Also, just FYI, the page at http://flexslider.woothemes.com/dynamic-carousel-min-max.html is still broken, presumably because it's not referencing 2.2.0.

Owner

mattyza commented Apr 24, 2013

We're hoping to merge into master within the next few weeks and will update the demo, etc, then.

If you spot any other items you reckon need a tweak or bug fix, please do continue to submit pull requests on the "develop" branch. :)

@jeffikus jeffikus closed this Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment