Fixed slider.play() leaving unstoppable setIntervals. #714

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

akapa commented Jun 5, 2013

If you call slider.play() more than once in a row, previous intervals are not cleared. Reference is lost to them, so they can never be stopped again and stack up. The fix calls clearInterval first if the slider is already playing.

@akapa akapa Fixed slider.play() leaving unstoppable setIntervals.
If you call slider.play() more than once in a row, previous intervals are not cleared. Reference is lost to them, so they can never be stopped again and stack up. The fix calls clearInterval first if the slider is already playing.
4f2a7d3
Owner

mattyza commented Jul 2, 2013

Merged manually. Thank you! :)

mattyza closed this Jul 2, 2013

akapa deleted the unknown repository branch Jul 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment