issue: IE10 fixes made for flexslider #900

Merged
merged 1 commit into from Dec 13, 2013

Conversation

Projects
None yet
5 participants

IE10 fixes made for flexslider.

@mattyza mattyza referenced this pull request Dec 13, 2013

Closed

Fix ie10 issue #899

mattyza added a commit that referenced this pull request Dec 13, 2013

@mattyza mattyza merged commit a609b52 into woocommerce:master Dec 13, 2013

This library is not working because patches are not merged properly. It replace jquery.flexslider-min.js with jquery.flexslider.js. SO giving js error.

Owner

mattyza commented Dec 19, 2013

Note that master is a bleeding edge version. Please grab the latest tagged release, before logging a ticket. Thanks. :)

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Thursday 19 December 2013 at 12:19 PM, SachinEbizon wrote:

This library is not working because patches are not merged properly. It replace jquery.flexslider-min.js with jquery.flexslider.js. SO giving js error.


Reply to this email directly or view it on GitHub (woothemes#900 (comment)).

My understanding is that master is broken because the merge from #900 introduces a broken jquery.flexslider.min.js (see line 5).

The latest tagged release, 2.2.1, has a jquery.flexslider-min.js that does not match the nonminified jquery.flexslider.js. Thus, 2.2.1 is also broken.

I also have a broken jquery.flexslider.min.js as it includes all the merge conflict code which is breaking it. This is in version 2.2.1 which I just downloaded from your website.

Owner

mattyza commented Dec 20, 2013

Fixing soonest. Thank you. :)

Owner

mattyza commented Dec 20, 2013

Fixed in 2.2.2, under the "Releases" menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment