Catch touch event on slides for asNavi mode #941

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@asabirov

Slides doesn't react on touch in ios Safari when using slider as navigation.

@thomasgriffin

This comment has been minimized.

Show comment Hide comment
@thomasgriffin

thomasgriffin Dec 12, 2013

Contributor

Instead of your event, you should use the "eventType" property as it will catch click, touch and Windows 8 gestures as well.

slider.slides.on(eventType, function(e){

Contributor

thomasgriffin commented Dec 12, 2013

Instead of your event, you should use the "eventType" property as it will catch click, touch and Windows 8 gestures as well.

slider.slides.on(eventType, function(e){

@mattyza

This comment has been minimized.

Show comment Hide comment
@mattyza

mattyza Dec 12, 2013

Member

Good call, Thomas. Would you mind submitting a pull request for this, please? :)

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Thursday 12 December 2013 at 6:28 PM, Thomas Griffin wrote:

Instead of your event, you should use the "eventType" property as it will catch click, touch and Windows 8 gestures as well.
slider.slides.on(eventType, function(e){


Reply to this email directly or view it on GitHub (woothemes#941 (comment)).

Member

mattyza commented Dec 12, 2013

Good call, Thomas. Would you mind submitting a pull request for this, please? :)

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Thursday 12 December 2013 at 6:28 PM, Thomas Griffin wrote:

Instead of your event, you should use the "eventType" property as it will catch click, touch and Windows 8 gestures as well.
slider.slides.on(eventType, function(e){


Reply to this email directly or view it on GitHub (woothemes#941 (comment)).

@thomasgriffin

This comment has been minimized.

Show comment Hide comment
@thomasgriffin

thomasgriffin Dec 12, 2013

Contributor

Submitted.

Contributor

thomasgriffin commented Dec 12, 2013

Submitted.

@mattyza mattyza closed this in 5f5a9ca Dec 13, 2013

mattyza added a commit that referenced this pull request Dec 13, 2013

Merge pull request #942 from thomasgriffin/master
Changes events to use on( eventType ). Fixes #941.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment