New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #958. Declare onTouchStart as a function expression. #986

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@miketaylr
Copy link
Contributor

miketaylr commented Jan 16, 2014

This way it gets hoisted properly and we don't rely on undefined
behavior (which doesn't work in some browsers).

@miketaylr

This comment has been minimized.

Copy link
Contributor Author

miketaylr commented Mar 21, 2014

Updated so this won't break anything. >_>

(Is this project actively maintained?)

@miketaylr miketaylr force-pushed the miketaylr:958-firefox-fix branch from 40b8818 to 77a004d Apr 28, 2015

Fixes #958. Declare onTouchStart, onTouchEnd, onTouchMove as function…
… expressions.

This way they get hoisted properly and we don't rely on undefined
behavior (which doesn't work in some browsers).

@miketaylr miketaylr force-pushed the miketaylr:958-firefox-fix branch from 77a004d to 887f6ff Apr 28, 2015

@miketaylr

This comment has been minimized.

Copy link
Contributor Author

miketaylr commented Apr 28, 2015

OK, just rebased against the latest master. cc @jeffikus.

@simevidas

This comment has been minimized.

Copy link

simevidas commented Apr 30, 2015

FWIW, I’ve reviewed the changes. LGTM

@jeffikus jeffikus self-assigned this May 4, 2015

@jeffikus jeffikus closed this May 19, 2015

@jeffikus

This comment has been minimized.

Copy link
Member

jeffikus commented May 19, 2015

see #1335

@miketaylr miketaylr deleted the miketaylr:958-firefox-fix branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment