Add release confirmation step to extension release PR #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martynmjones
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Hey @tomalec, thanks for updating the release workflow.
The additional checklist item for wporg release confirmation is clear on what action need to be taken so looks fine to me.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Add release confirmation step to extension release PR
Recently, the "release notifications" were enabled for WPORG plugins. This PR adds a step to confirm the release.
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
To create the PR and test it E2E we would need to (test) release it and use in a repo.
As this PR does not change any logic related to PR creation, just the message, I hope proof-reading the new PR body would be enough.
Additional details:
Changelog entry