Add self-test for PHPCompatibility to not flag attribute usage #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongruige
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Slack, attributes are usually backwards compatible with PHP 7, for the exception or multi-line attributes.
PHPCompatibility currently cannot differentiate between them and flags all usage of Attributes as invalid if you plan to support PHP 7.
We disabled the Attribute rule in the PHPCompatibility test as it's currently causing more false-positives than bringing benefits, as multi-line attribute usage is very rare in WP plugins, but
ReturnTypeWillChangeis very common, for instance.We are keeping an eye upstream for when PHPCompatibility have a way to differentiate both, and will re-enable this rule.