Ensure HTML escaping only occurs for strings #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
This looks like it'll do the job. It feels a bit weird to drop sanitization of non-strings here, but it seems like the only method it is actually used (Scd_Ext_Lesson_Admin::content_drip_lesson_meta_content()) things get re-sanitized.
I tried looking more at version history and couldn't see where we might have stored a value as DateTime. Seems pretty strange.
|
@donnapep Restored branch. This PR needs to be re-opened for merging into |
|
Sorry for the blunder on this one! I couldn't reopen this PR, so I opened a new one instead: #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Note that I was not able to reproduce the fatal mentioned in that issue.
Also note that I built this on top of #146 in order to work with Sensei 2.0. I will rebase when #146 is merged.
Testing instructions
See #124. Ensure content drip works.