Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure emails are sent at 00:30 in the WordPress-configured timezone #149

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@alexsanford
Copy link
Contributor

commented Mar 7, 2019

Fixes #91

Schedules the cron job to run at 00:30 in the timezone set in the WordPress settings.

Note that I built this on top of #146 in order to work with Sensei 2.0. I will rebase when #146 is merged.

Testing instructions

  • Deactivate and reactivate the plugin.
  • Inspect the cron jobs (the plugin WP Crontrol is useful for this).
  • Ensure the cron job woo_scd_daily_cron_hook is set to run tomorrow at 00:30 (12:30am) in the timezone configured in WordPress.
  • In WordPress settings, change the timezone to one whose current date is different.
  • Follow the steps above. Ensure the cron job is set to run on the following day at 00:30 relative to the configured timezone.

@alexsanford alexsanford added this to the 1.1.0 milestone Mar 7, 2019

@alexsanford alexsanford self-assigned this Mar 7, 2019

@alexsanford alexsanford requested review from jom and donnapep Mar 7, 2019

@jom

jom approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

Looks good; works well.

@alexsanford alexsanford changed the base branch from change/deps-check to master Mar 8, 2019

@alexsanford alexsanford merged commit 7475099 into master Mar 8, 2019

@alexsanford alexsanford deleted the change/email-send-time branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.