Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable translating "Give Access" and "Remove Access" button text #157

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@alexsanford
Copy link
Contributor

alexsanford commented Mar 12, 2019

Closes #140

To test, use a plugin such as Loco Translate to add translations for the text "Give Access" and "Remove Access". Then follow the instructions from #140. You should see the translated text on the button.

@alexsanford alexsanford self-assigned this Mar 12, 2019

@alexsanford alexsanford requested review from jom and donnapep Mar 12, 2019

@donnapep
Copy link
Contributor

donnapep left a comment

Works great! 👍

@alexsanford alexsanford merged commit 6c506fc into master Mar 13, 2019

@alexsanford alexsanford deleted the fix/button-text-i18n branch Mar 13, 2019

@alexsanford alexsanford added this to the 2.0.0 milestone Mar 13, 2019

@donnapep donnapep changed the title Add i18n for button text Enable translating "Give Access" and "Remove Access" button text Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.