Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix lesson order in drip email #172
Lessons can be ordered by two separate ways, by module or by lesson.
The automated tests for content drip are not configured to run at the moment. I spent some time trying to add a test and run it but unfortunately it proved to be a time consuming task so I skipped adding automated tests.
Manual test cases that were executed:
To test the functionality follow the instructions outlined in #154
Lessons can be ordered by two separate ways, by module or by lesson. Previously, the lessons in the emails were only ordered if a lesson order was defined and the module ordering was ignored. This is now fixed.
Hey @donnapep I have added extra logic to sort the lessons if they don't belong in a module so this should now work.
There is still a chance for the 'Other lessons' to still not have the same ordering in case that they don't have the order$course_id meta set. The lessons that don't have this meta value are appended in the end with no particular order in both the frontend and the email ordering code.
donnapep left a comment •
This works well.