Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load most of plugin and check dependencies after other plugins have loaded #33

merged 3 commits into from Mar 19, 2019


None yet
2 participants
Copy link

commented Mar 19, 2019

This brings over the work to check dependencies and load plugin after the other plugins have loaded. This simplifies our Sensei check and makes it work for non-standard install locations.

Testing Instructions

  • If activated, deactivate all versions of Sensei.
  • Remove sensei-version and woothemes-sensei-version options.
  • If not active, activate this plugin on built version of this branch. Verify the Sensei dependency message shows on Plugins page and Dashboard page.
  • Activate Sensei 1.12.x. Verify message disappears.
  • Deactivate Sensei 1.12.x. Activate Sensei 2.x. Verify message is still gone.
  • Deactivate Sensei 2.x and activate Sensei with WooCommerce Paid Courses. Verify message is still gone.

Test PHP version:

  • Activate Sensei and version of this branch on PHP 5.2-5.5. Verify PHP version notice appears.

In addition:

  • Make sure version is logged in options (sensei_course_participants_version) on activation even when Sensei isn't first activated.

@jom jom added this to the 2.0.0 milestone Mar 19, 2019

@jom jom requested review from alexsanford and donnapep Mar 19, 2019

Copy link

left a comment

Looks good, seems to work! 🎉

@jom jom merged commit 57d1145 into master Mar 19, 2019

@jom jom deleted the change/deps-check-on-load branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.