Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove h3 heading from participant name #35

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
3 participants
@alexsanford
Copy link
Contributor

commented Mar 19, 2019

Fixes #19

Note: command to build the CSS file is: sass -s compressed --no-source-map assets/css/frontend.scss assets/css/frontend.css

Testing Instructions

Add the Course Participants widget to the sidebar. Ensure that everything behaves as before, except the user display names are not h3 headings.

@alexsanford alexsanford added this to the 2.0.0 milestone Mar 19, 2019

@alexsanford alexsanford self-assigned this Mar 19, 2019

@alexsanford alexsanford requested review from jom and donnapep Mar 19, 2019

@jom

jom approved these changes Mar 20, 2019

Copy link
Contributor

left a comment

Looks good; works well. You removed the itemprop, which makes sense because I don't see an itemscope so I'm not sure it was doing anything?

@alexsanford

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@jom Actually, that was an oversight on my part. Good catch.

It's possible that the itemprop isn't doing anything, but I do see that it is also added to the figure element. I've added it back in, in case someone is using it for something. We could evaluate and possible remove the itemprop's in another PR.

@alexsanford alexsanford merged commit 2bd7ec7 into master Mar 20, 2019

@alexsanford alexsanford deleted the fix/participant-name-heading branch Mar 20, 2019

@donnapep
Copy link
Contributor

left a comment

Added a comment re: element choice. Also, there's an obsolete h3 selector in the CSS.

@alexsanford alexsanford referenced this pull request Mar 21, 2019

Merged

Clean up tag usage #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.