Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations not loading #82

Merged
merged 2 commits into from Nov 17, 2019
Merged

Fix translations not loading #82

merged 2 commits into from Nov 17, 2019

Conversation

@donnapep
Copy link
Contributor

donnapep commented Nov 15, 2019

The translations were not loading because the plugin was looking in the lang folder, when in fact the folder is actually named languages. There were also some incorrect text domains which have been updated.

Testing

  1. In Settings > General, change the Site Language to Russian (i.e. Русский).
  2. Go to Appearance > Widgets.
  3. Look for the Sensei LMS - Course Progress widget.
  4. Ensure the description is translated.
  5. Add the widget to the sidebar.
  6. Ensure the widget checkbox setting is translated.
@donnapep donnapep added this to the 2.1.0 milestone Nov 15, 2019
@donnapep donnapep self-assigned this Nov 15, 2019
@donnapep donnapep requested review from jom, gkaragia and alexsanford Nov 15, 2019
@donnapep donnapep force-pushed the fix/translations-not-loading branch from 238ea9b to e51c6e7 Nov 15, 2019
Copy link

gkaragia left a comment

Looks good!

@donnapep donnapep merged commit af2afe2 into master Nov 17, 2019
@donnapep donnapep deleted the fix/translations-not-loading branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.