Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to load most of plugin after other plugins have loaded #43

Merged
merged 4 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@jom
Copy link
Contributor

commented Mar 19, 2019

This brings over the work to check dependencies and load plugin after the other plugins have loaded. This simplifies our Sensei check and makes it work for non-standard install locations.

Testing Instructions

  • If activated, deactivate all versions of Sensei.
  • Remove sensei-version and woothemes-sensei-version options.
  • If not active, activate this plugin on built version of this branch. Verify the Sensei dependency message shows on Plugins page and Dashboard page.
  • Activate Sensei 1.12.x. Verify message disappears.
  • Deactivate Sensei 1.12.x. Activate Sensei 2.x. Verify message is still gone.
  • Deactivate Sensei 2.x and activate Sensei with WooCommerce Paid Courses. Verify message is still gone.

Test PHP version:

  • Activate Sensei and version of this branch on PHP 5.2-5.5. Verify PHP version notice appears and plugin self-deactivates.

@jom jom added this to the 2.0.0 milestone Mar 19, 2019

@jom jom requested review from alexsanford and donnapep Mar 19, 2019

@donnapep
Copy link
Contributor

left a comment

Couple of comments before I test this out.

Show resolved Hide resolved classes/class-sensei-media-attachments.php Outdated
Show resolved Hide resolved classes/class-sensei-media-attachments.php Outdated
Show resolved Hide resolved classes/class-sensei-media-attachments.php Outdated
@alexsanford
Copy link
Contributor

left a comment

👍

@jom jom merged commit a144716 into master Mar 19, 2019

@jom jom deleted the change/deps-check-on-load branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.