Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attachment title for the label of the file #45

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@jom
Copy link
Contributor

commented Mar 19, 2019

Fixes #14

This uses the media title for the label when listing attachments. It also introduces the new filter sensei_media_attachments_get_attachment_title for overriding the title.

Testing Instructions

  1. Update the title for attached media when uploading.
  2. Attach the file to a course and/or lesson.
  3. Verify the updated title is displayed on the frontend.

@jom jom added the Hooks & Filters label Mar 19, 2019

@jom jom requested review from alexsanford and donnapep Mar 19, 2019

@alexsanford alexsanford added this to the 2.0.0 milestone Mar 19, 2019

@alexsanford
Copy link
Contributor

left a comment

Looks good, works well. I like the filter, too! 🙂

@jom jom merged commit 9d206c6 into master Mar 19, 2019

@jom jom deleted the change/media-title branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.