Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency check for Sensei 2 and PHP version #19

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@jom
Copy link
Contributor

commented Mar 12, 2019

Brings the work from the Content Drip PR over to Sensei Certificates: woocommerce/sensei-content-drip#146

In addition, this PR moves the main class to its own file. This is both best practice and needed for the PHP dependency check to be useful. In order to do this, I introduced a new SENSEI_SHARE_YOUR_GRADE_PLUGIN_BASENAME constant and replaced usages of plugin_basename( __FILE__ ) with that constant.

Testing Instructions

  • If activated, deactivate all versions of Sensei.
  • Remove sensei_version and woothemes_sensei_version options.
  • If not active, activate this plugin on this branch. Verify the Sensei dependency message shows on Plugins page and Dashboard page.
  • Activate Sensei 1.12.x. Verify message disappears.
  • Deactivate Sensei 1.12.x. Activate Sensei 2.x. Verify message is still gone.
  • Deactivate Sensei 2.x and activate Sensei with WooCommerce Paid Courses. Verify message is still gone.

Test PHP version:

  • Activate Sensei and version of this branch on PHP 5.2-5.5. Verify PHP version notice appears.

@jom jom added this to the 2.0.0 milestone Mar 12, 2019

@jom jom requested review from alexsanford and donnapep Mar 12, 2019

@alexsanford
Copy link
Contributor

left a comment

Tested this along with the others. Aside from having the same comment as with course progress, this looks good.

@jom jom merged commit db235a3 into master Mar 13, 2019

@jom jom deleted the update/deps-check branch Mar 13, 2019

@matticbot matticbot referenced this pull request Apr 25, 2019

Closed

Update extensions #2539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.