Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] changes on static, full-width homepage.... #1127

Closed
GlennMartin1 opened this issue May 9, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@GlennMartin1
Copy link
Contributor

commented May 9, 2019

Wordpress 5.2.0
Storefront 2.5
Homestore 2.0.31
Powerpack 1.4.15

On my homepage, I have it set as "Full Width"
Also, it is set as a "static" page in the Customizer.

Since upgrading to Storefront 2.5, there's two (related?) issues:

  • the homepage title disappeared
  • the pics are not wrapping properly as before

Here a Before and After image:

BEFORE (Storefront 2.4.6):

before

AFTER (Storefront 2.5):

after

@GlennMartin1

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

On 7 sites I've upgraded (to Storefront 2.5) so far, 4 have this issue, 3 do not.

They all have the same site environment (listed in above post). Not clear what the difference is.

All have the homepage content in the new editor.
All running Gutenberg plugin (but same issue with Gutenberg plugin deactivated).


Regarding the image wrapping, perhaps this image could be a clue for you:
after 2

@tiagonoronha

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

@GlennMartin1 in 2.5 we repurposed the "full width" template as a way to create landing pages without a page title. Sorry if this is causing you trouble.

You can manually add a heading to the post content, it will show basically the same as the title.

If you don't have any widgets in the sidebar, you can also remove the "Full Width" template from that page and the layout should still stay full width, but with the title.

@GlennMartin1

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

Thanks for your patience with this issue....

The "Full-width" template has no title (shouldn't each page have an H1?). Plus this template has text-wrap issues, and an unwanted white-space before content begins (area where the title used to be).

Great theme otherwise - not wanting to complain - but the homepage is just not working.

@tiagonoronha

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@GlennMartin1 the image wrapping is a different issue that is not related to the changes we made. I'll address it in a different issue.

As for the changes to the title, the change made was to not show the title when a page with the "Full Width" template is assigned as the frontpage.

I just tested creating a page with the default template, then I assigned it to be the front page and the title is showing:

Screenshot 2019-05-13 at 12 48 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.