New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout sticky payment not working when the checkout page change size with JavaScript #719

Closed
jesucarr opened this Issue Jan 8, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jesucarr

jesucarr commented Jan 8, 2018

I have a plugin that loads the checkout page with some elements hidden and then shows them up. In your checkout.js you assume the height will be always the same as when loaded, so it doesn't work correctly. The fix is simple: move the 2 first lines where you store the heights values inside the stickyPayment function so it gets updated. I'll submit a PR shortly.

@tiagonoronha

This comment has been minimized.

Show comment
Hide comment
@tiagonoronha
Contributor

tiagonoronha commented Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment