Skip to content

Conversation

@adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Jun 18, 2025

Closes QAO-27
Contributes to QAO-23

Pins Github actions to full commit SHAs as immutable references. Also bumped actions/upload-artifact to v4, the e2e-tests workflow was failing because v3 was deprecated (not sure why #2180 missed it).
Skipped all official GitHub actions and only pinned other 3rd party ones.
No version updates - used the latest commit in the tag that was already used, except the actions/upload-artifact mentioned above.

@adimoldovan adimoldovan self-assigned this Jun 18, 2025
@adimoldovan adimoldovan marked this pull request as ready for review June 18, 2025 12:58
@adimoldovan adimoldovan requested review from a team and gigitux and removed request for a team June 19, 2025 14:49
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🙇

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Jun 20, 2025
@adimoldovan adimoldovan merged commit faebb41 into trunk Jun 20, 2025
7 checks passed
@adimoldovan adimoldovan deleted the dev/pin-github-actions branch June 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants