Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added German translation #38

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Member

corsonr commented Jan 6, 2014

Added German Translation. Provided by Alf Koblischke.

Owner

mattyza commented Jan 6, 2014

@corsonr - Thanks for this.

Generally, we prefer not to include multiple translations in plugins/themes, as they add bulk to the plugin and become cumbersome to maintain and do QA on.

@jameskoster, your thoughts?

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Monday 06 January 2014 at 10:33 AM, Remi Corson wrote:

Added German Translation. Provided by Alf Koblischke.
You can merge this Pull Request by running
git pull https://github.com/corsonr/testimonials master
Or view, comment on, or merge it at:
woothemes#38
Commit Summary
Added German translation

File Changes
A lang/woothemes-testimonials-de_DE.mo (https://github.com/woothemes/testimonials/pull/38/files#diff-0) (0)
A lang/woothemes-testimonials-de_DE.po (https://github.com/woothemes/testimonials/pull/38/files#diff-1) (404)

Patch Links:
https://github.com/woothemes/testimonials/pull/38.patch
https://github.com/woothemes/testimonials/pull/38.diff


Reply to this email directly or view it on GitHub (woothemes#38).

Owner

jameskoster commented Jan 6, 2014

Yeah I lean towards third party services for managing translations. As you know we're using transifex in WooCommerce and it's working well so far.

wvega commented May 26, 2014

@jameskoster that's a fair point. However, even if the translations are managed in a third party service I believe it would be good to have all translations under the same service. It is easier to contribute and easier for users to find the translations, IMO.

I will have an spanish translation ready soon and I imagine others may benefit from it in the future. Is there any plan to provide for this plugin something like the transifex project you have for WooCommerce, so that third party developers/translators can contribute their translations?

Owner

mattyza commented May 27, 2014

We'll get the Testimonials plugin set up in Transifex. Once this is ready,
I'll post a note here.

Matt Cohen
Chief Product Officer, WooThemes

http://woothemes.com/
http://matty.co.za/

On Mon, May 26, 2014 at 11:53 PM, Willington Vega
notifications@github.comwrote:

@jameskoster https://github.com/jameskoster that's a fair point.
However, even if the translations are managed in a third party service I
believe it would be good to have all translations under the same service.
It is easier to contribute and easier for users to find the translations,
IMO.

I will have an spanish translation ready soon and I imagine other may
benefit from it in the future. Is there any plan to provide for this plugin
something like the transifex project you have for WooCommerce, so that
third party developers/translators can contribute their translations?


Reply to this email directly or view it on GitHubhttps://github.com/woothemes/testimonials/pull/38#issuecomment-44220113
.

Owner

mattyza commented May 27, 2014

This project is now set up for translation in Transifex, here:
https://www.transifex.com/projects/p/testimonials-by-woothemes/

(Transifex is a solution which enables us to easily regulate translations
and pull them into the plugin as needed, without the need for managing,
reviewing and auditing translation files via Github.) :)

Matt Cohen
Chief Product Officer, WooThemes

http://woothemes.com/
http://matty.co.za/

On Tue, May 27, 2014 at 7:40 AM, Matt Cohen matt@woothemes.com wrote:

We'll get the Testimonials plugin set up in Transifex. Once this is ready,
I'll post a note here.

Matt Cohen
Chief Product Officer, WooThemes

http://woothemes.com/
http://matty.co.za/

On Mon, May 26, 2014 at 11:53 PM, Willington Vega <
notifications@github.com> wrote:

@jameskoster https://github.com/jameskoster that's a fair point.
However, even if the translations are managed in a third party service I
believe it would be good to have all translations under the same service.
It is easier to contribute and easier for users to find the translations,
IMO.

I will have an spanish translation ready soon and I imagine other may
benefit from it in the future. Is there any plan to provide for this plugin
something like the transifex project you have for WooCommerce, so that
third party developers/translators can contribute their translations?


Reply to this email directly or view it on GitHubhttps://github.com/woothemes/testimonials/pull/38#issuecomment-44220113
.

@mattyza mattyza closed this Feb 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment