Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Honor WooCommerce Settings When Formatting Currency/Price #1342
This PR seeks to format numbers and prices using the store's format settings (WooCommerce > Settings > Currency Options). It makes use of a JS port of PHP's
In addition to reworking
Detailed test instructions:
timmyc left a comment
This is great to see! We already had some feedback around currency formatting on one of the release posts, so this will save quite a bit of bug reports over the coming months - thanks Jeff!
Had a few questions in the code, but overall looking fantastic. Could you also add a note to CHANGELOG.md in the
Aljullu left a comment
Closing two issues in one PR.
This is testing well for me, couldn't find any number that is not correctly formatted. I just added a couple of comments inline with the code.