Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add performance indicators to dashboard #1343
This PR hooks up the performance indicators on the dashboard to the new performance indicator REST API.
It also makes some more adjustments to the REST API to make this possible including report links, description/label, chart sorting, and a method of indicating which total should be a performance indicator and of what format.
A few stats off the list in #1282 are missing, because they do not exist in the reports/REST API yet. Once added, they will automatically show up here.
Detailed test instructions:
timmyc left a comment
Some minor comments in the code - I think the only real change might be API versioning. Tests are passing for me, and thanks for adding/updating them.
I'm going to test out the FUE extension too to get the full experience too, but did want to drop this .gif here as when I first activated this branch, and visited the dashboard, this is what I was seeing - its like there is an initial load, and then a subsequent refresh added in two more indicators. Once I toggled some off, and thus had user preferences set, I could no longer see the issue:
Other than that, this is testing out wonderfully for me, and really takes the dashboard utility level up immensely. Being able to customize these stats, and quickly dive in deeper for further analysis is a real treat that I'm certain store operators will love.
@timmyc It took me a bit to debug/track down what was happening with the preferences but I think the issue is fixed now. I've also handled the other PR feedback and rebased this.
If the code looks OK, since this PR is a bit bigger, I wouldn't mind getting this merged and handle any larger changes / design feedback in a future PR.