Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search List Control: fix long count values cut-off in IE11 #2783

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@Aljullu
Copy link
Contributor

commented Aug 13, 2019

Screenshots

Before:
image

After:
image

Detailed test instructions:

		return <SearchListItem countLabel="Lorem Ipsum" showCount { ...args } />;
  • Go to WooCommerce > DevDocs.
  • Go to SearchListControl card and press Toggle loading state.
  • Verify the count label appears entirely in IE11.

@Aljullu Aljullu requested a review from woocommerce/wc-admin Aug 13, 2019

@Aljullu Aljullu self-assigned this Aug 13, 2019

@Aljullu Aljullu added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 13, 2019

@joshuatf
Copy link
Contributor

left a comment

Testing well! Thanks for the fix, @Aljullu!

@Aljullu Aljullu merged commit 37e1412 into master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 15, 2019

@Aljullu Aljullu deleted the fix/search-list-control-item-count-ie11 branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.