Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Scripts: Update to reflect refactor #2796

Merged
merged 5 commits into from Aug 15, 2019

Conversation

@psealock
Copy link
Collaborator

commented Aug 14, 2019

  1. Don't exclude package-lock.json changes in the release. That file never gets included in the release anyways, but we may as well keep it up to date with the latest version.
  2. Modify the prestart script to update the version numbers in correct files now that the structure has changed.

Testing

  1. change the version in package.json.
  2. npm run prestart.
  3. Check that woocommerce-admin.php and src/FeaturePlugin.php have correctly updated version numbers.

@psealock psealock requested a review from woocommerce/wc-admin Aug 14, 2019

@psealock psealock added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 14, 2019

@probot-autolabeler probot-autolabeler bot added the Build label Aug 14, 2019

@psealock psealock changed the title Release Script: Add composer install Release Scripts: Update to reflect refactor Aug 15, 2019

@psealock psealock referenced this pull request Aug 15, 2019
psealock added 3 commits Aug 15, 2019
@joshuatf
Copy link
Contributor

left a comment

Testing well- thanks for updating this, Paul!

@psealock psealock merged commit dd3ff72 into master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 15, 2019

@psealock psealock deleted the fix/pre-release-script-composer branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.