Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty state to tables #2801

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@jeffstieler
Copy link
Contributor

commented Aug 15, 2019

Fixes #2613.

This PR seeks to add an empty state to Tables.

In the empty state:

  • A message is displayed (same as the chart)
  • All table controls are disabled/noop-ed except for column visibility

Screenshots

Screen Shot 2019-08-15 at 12 59 59 PM

Detailed test instructions:

  • Open a report
  • Select a date range that has no data
  • Verify the "no data" message in the table
  • Verify the columns can still have their visiblity toggled
  • Verify that all report table inputs are disabled (compare, search)

Changelog Note:

Tweak: add empty dataset treatment for report tables.

@jeffstieler jeffstieler requested a review from woocommerce/wc-admin Aug 15, 2019

@jeffstieler jeffstieler added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 15, 2019

@joshuatf
Copy link
Contributor

left a comment

Testing well and LGTM! :shipit:

Unrelated to this PR, but noticed while testing that my woocommerce-ellipsis-menu__toggle is slightly cut off. Do you see this?

Screen Shot 2019-08-16 at 2 04 35 PM

@jeffstieler

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Unrelated to this PR, but noticed while testing that my woocommerce-ellipsis-menu__toggle is slightly cut off. Do you see this?

Yes I do - I made sure it was still occurring on master and then promptly forgot about it 😅.

@jeffstieler jeffstieler merged commit 28bf7f9 into master Aug 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 16, 2019

@jeffstieler jeffstieler deleted the add/2613-empty-table-state branch Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.