Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "show data picker" prop to underlying component in ReportFilters. #2805

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@jeffstieler
Copy link
Contributor

commented Aug 16, 2019

Fixes errant date picker on the Customers Report.

Fixes #2773.

The date range picker was errantly displaying on the Customers Report because the showDatePicker prop wasn't being passed down to the underlying ReportFilters component.

Screenshots

Screen Shot 2019-08-16 at 10 06 35 AM

Detailed test instructions:

  • Go to Analytics > Customers
  • Verify there is no date picker

Changelog Note:

Fix: remove date picker from Customers Report.

Pass "show data picker" prop to underlying component in ReportFilters.
Fixes errant date picker on the Customers Report.

@jeffstieler jeffstieler requested a review from woocommerce/wc-admin Aug 16, 2019

@jeffstieler jeffstieler added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 16, 2019

@psealock
Copy link
Collaborator

left a comment

Wow, that snuck in there during a refactor #2525. Thanks for addressing, LGTM 🚢

@jeffstieler jeffstieler merged commit 7f5b4ae into master Aug 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 19, 2019

@jeffstieler jeffstieler deleted the fix/2773-date-range-customers-report branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.