Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Remove unused data endpoints param #8379

Merged
merged 2 commits into from Feb 28, 2022

Conversation

louwie17
Copy link
Contributor

Partially addresses #8373

Removes unused data endpoint used for the preload data in wcSettings. This will remove 182kB of data, and likely remove some delay on initial page load.

Detailed test instructions:

  • Search repo for any references of uses of routes from wcSettings.dataEndpoints[0].routes there shouldn't be any
  • Do a quick smoke test of the app to make sure things still work as expected.

Copy link
Contributor

@jacob-sewell jacob-sewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, looked for remaining references to preloaded data. Looks good to me!

@louwie17 louwie17 merged commit 143456b into main Feb 28, 2022
@louwie17 louwie17 deleted the fix/8373_dataendpoints_wc_v3_settings branch February 28, 2022 22:51
ObliviousHarmony pushed a commit to woocommerce/woocommerce that referenced this pull request Mar 10, 2022
* Remove unused data endpoints param

* Add changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants