[Woo POS] Adapt the UI to be usable on smaller devices #11940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions-improvements' into 11937-woo-pos-adapt-the-ui-to-be-usable-on-smaller-devices
kidinov
added
the
status: do not merge
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
backwardstruck
approved these changes
Jul 8, 2024
Contributor
backwardstruck
left a comment
backwardstruck
left a comment
There was a problem hiding this comment.
Code changes look good.
Testing on small screen tablet:
Large screen tablet testing:
| import com.woocommerce.android.ui.woopos.util.ext.getLongestScreenSideDp | ||
|
|
||
| @Composable | ||
| fun Dp.toAdaptivePadding(): Dp { |
Contributor
There was a problem hiding this comment.
Nice way to ensure padding is adjusted based on screen size.
Contributor
Author
There was a problem hiding this comment.
@samiuelson wdyt about this approach? That's kinda naive, but it seems to be working
Also, if we go with this, we should not forget to use that on all the paddings
…ions-improvements' into 11937-woo-pos-adapt-the-ui-to-be-usable-on-smaller-devices
…ements' into 11937-woo-pos-adapt-the-ui-to-be-usable-on-smaller-devices
Base automatically changed from
11895-woo-pos-entry-point-eligibility-conditions-improvements
to
trunk
July 11, 2024 12:25
kidinov
removed
the
status: do not merge
1 task
kidinov
deleted the
11937-woo-pos-adapt-the-ui-to-be-usable-on-smaller-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11937
Description
Adapts the UI to be more usable on smaller screens
Steps to reproduce
Testing information
Test the changes on different screen size:
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.