From 7f7d31a9b942b861185cdc6a652129275df91402 Mon Sep 17 00:00:00 2001 From: samiuelson Date: Fri, 19 May 2023 14:08:49 +0200 Subject: [PATCH] Add "coupons_count" property to ORDER_CREATION_SUCCESS event --- .../com/woocommerce/android/analytics/AnalyticsTracker.kt | 2 ++ .../android/ui/orders/creation/OrderCreateEditViewModel.kt | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt index a1813f0355c6..cd69c14e13c9 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt @@ -255,6 +255,8 @@ class AnalyticsTracker private constructor(private val context: Context) { const val KEY_TIME_ELAPSED_SINCE_ADD_NEW_ORDER_IN_MILLIS = "milliseconds_since_order_add_new" const val KEY_TIME_ELAPSED_SINCE_CARD_COLLECT_PAYMENT_IN_MILLIS = "milliseconds_since_card_collect_payment_flow" + const val KEY_COUPONS_COUNT = "coupons_count" + enum class OrderNoteType(val value: String) { CUSTOMER("customer"), PRIVATE("private"), diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt index 5048a9510db4..83010e62b975 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt @@ -24,6 +24,7 @@ import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_SHIPPING_METHOD_AD import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_SHIPPING_METHOD_REMOVE import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_STATUS_CHANGE import com.woocommerce.android.analytics.AnalyticsTracker +import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_COUPONS_COUNT import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_CONTEXT import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_DESC import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_TYPE @@ -432,11 +433,12 @@ class OrderCreateEditViewModel @Inject constructor( private fun trackOrderCreationSuccess() { tracker.track( ORDER_CREATION_SUCCESS, - mutableMapOf().also { mutableMap -> + mutableMapOf().also { mutableMap -> OrderDurationRecorder.millisecondsSinceOrderAddNew().getOrNull()?.let { timeElapsed -> mutableMap[AnalyticsTracker.KEY_TIME_ELAPSED_SINCE_ADD_NEW_ORDER_IN_MILLIS] = timeElapsed.toString() } + mutableMap[KEY_COUPONS_COUNT] = orderDraft.value?.couponLines?.size ?: 0 } ) }