This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart template part: give user customized template priority over theme template #9005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
block: mini-cart
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Aljullu
commented
Apr 11, 2023
| }, | ||
| $saved_woo_templates | ||
| ); | ||
| return BlockTemplateUtils::get_block_templates_from_db( $slugs, $template_type ); |
There was a problem hiding this comment.
I guess it's ok to move this function to BlockTemplateUtils.php?
There was a problem hiding this comment.
Should we use the BlockTemplateUtils::get_block_templates_from_db in line 448 and remove this one since it's just wrapping the BlockTemplateUtils one?
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
albarin
approved these changes
Apr 12, 2023
| }, | ||
| $saved_woo_templates | ||
| ); | ||
| return BlockTemplateUtils::get_block_templates_from_db( $slugs, $template_type ); |
There was a problem hiding this comment.
Should we use the BlockTemplateUtils::get_block_templates_from_db in line 448 and remove this one since it's just wrapping the BlockTemplateUtils one?
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Makes sense, done in 02c1ac5!
I'm not sure about this one. Given that this is a public method, another extension could have started using it and we might break it if we remove, no? Do you think we should mark it as deprecated (via |
Oh, that makes total sense, I didn't think about that case. We can deprecate it I guess. |
Aljullu
force-pushed
the
fix/8929-mini-cart-user-template-has-priority-over-theme-template
branch
from
c59eff4
to
7e82588
Compare
Aljullu
deleted the
fix/8929-mini-cart-user-template-has-priority-over-theme-template
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8929.
Testing
User Facing Testing
parts/mini-cart.htmlfile): twentytwentythree.zip.In other words, given that you created a custom template in step 1, you should never see the template from the theme.
WooCommerce Visibility
Performance Impact
Changelog