New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apple Pay] not working with Addons like Gravity forms, product bundles and the like #211

Closed
Deaner666 opened this Issue Mar 28, 2017 · 26 comments

Comments

Projects
None yet
6 participants
@Deaner666

Deaner666 commented Mar 28, 2017

What I expected

No change on update.

What happened instead

A broken site! Customers in mobile Safari and desktop Safari 10+ can place orders for products with a zero value. This doesn't occur on Chrome or Firefox on desktop. I haven't tested with Android browsers.

The process happens like this:

Action: On the single product page choose options and hit add to cart
Result: The cart updates with the correct value but an incorrect quantity (usually 2).

pasted_image_28_03_2017__10_44

Action: Click through to the cart
Result: The price has reverted to zero and quantity to 1

pasted_image_28_03_2017__10_39

OR:
Action: Click Apply Pay button
Result: Tries to take a payment of zero! (why is there even an Apple Pay button on the single product page. This should be off by default, with perhaps an option in settings to enable it).

If you proceed to checkout it continues to record a zero value (and no GF Addons options) for the product.

It only seems to happen on products that use a gravity form for customisation with the official Gravity Forms Addons extension.

The problem occurs on the latest stable release of WooCommerce, and also the WooCommerce 3 RC.

I'm certain this is to do with Apple Pay (Apple Pay is only available on the desktop via Safari 10+), but the problem exists whether Apple Pay is enabled or not. Disabling the entire Stripe extension returns the site to normal functionality (minus the ability to take card payments!).

Steps to reproduce the issue

I have tested this in the following scenarios:

Production: with SSL and caching (WP Engine) - Broken
Staging: with SSL, no caching (WP Engine) - Broken.
Local: SSL, no caching - Broken


  • Issue assigned to next milestone.
  • Issue assigned a priority (will be assessed by maintainers).
@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

I've had other people test this on Desktop and iPhone and they're not seeing the problem. I can't see any consistency as to why it's working in some cases and not others. I think it might be to do with whether or not Handoff between an iPhone with a verified card in Apple Wallet has connected with the person's desktop Safari as one person saw the error on their phone but not their desktop Safari.

@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

I've set up a staging site where you can try a live version:

https://print2media.staging.wpengine.com/product/foamex-signs/

I'll be interested to see who sees the problem and who doesn't.

Setups for testing:

  • iOS Safari
  • MacOs Safari 10+
  • MacOs Safari 10+ with a verified card in Apple Wallet on your phone
  • MacOs Safari 10+ with a verified card in Apple Wallet on your phone and Handoff active with your desktop
@roykho

This comment has been minimized.

Member

roykho commented Mar 28, 2017

This is correct. The new Stripe with Apple Pay is not made to work with any added extensions yet such as Product Addons, Gravity form addons..etc.

@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

Wow, really? How about a warning for all the existing stores using Stripe to take payments who will automatically update this plugin?

I mean this would be acceptable if the problems only occurred when Apple Pay was turned on but this extension is breaking sites even with Apple Pay turned off.

I mean how many people are running WooCommerce stores that don't have some other kind of extension running?

I'm now having to revert multiple sites to 3.0.7 as it's the latest version that's fit for purpose.

@roykho

This comment has been minimized.

Member

roykho commented Mar 28, 2017

Perhaps you misunderstood. What I mean is addons that manipulates the price and added custom fields. And this only effects Apple Pay. If you have it turned off, you can use them. You can test this against master branch.

@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

Perhaps you didn't read my original post in detail. The problems occur even when Apple Pay is disabled. I have tested this thoroughly on multiple sites in production/staging/dev.

And there are many extensions that manipulate the price. Even if you limit your choice of extensions (as I do) to the official ones from yourselves (WooCommerce/Automattic). I don't expect every extension to be compatible with every other. But I do generally expect the official WooCommerce extensions sold together in your official marketplace to play well together. And historically they have.

I notice you used the term MVP (Minimum Viable Product) in another thread where someone is having problems with compatibility with the Dynamic Pricing extension (another one I use myself regularly). You really can't treat this extension as an MVP. It's an established plugin used on lord knows how many thousands of sites. Businesses rely on this to transact, it shouldn't be a playground for experimentation.

If you want to play with an MVP Apple Pay extension, make it a separate plugin that's dependent on this one.

@roykho

This comment has been minimized.

Member

roykho commented Mar 28, 2017

Again, did you test with master branch? This issue shouldn't happen if Apple Pay is disabled.

@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

No. I've been testing with the most recent version (3.1.3) that is live in the wild and available via automatic update. I will test with master now.

@Deaner666

This comment has been minimized.

Deaner666 commented Mar 28, 2017

OK, I've only had a chance to test this on dev so far... but master branch does seem to have fixed the issue as long as Apple Pay is disabled. I've got to finish for the day but I'll test on prod and staging tomorrow. Looks like it should be fine though.

Thanks for that update... roll it out live as soon as!

@roykho

This comment has been minimized.

Member

roykho commented Mar 28, 2017

Yeah this should be rolled out sometime tomorrow.

@roykho roykho changed the title from 3.1.3 not working in Safari 10+ with products that use the Gravity Forms Addons extension to [Apple Pay] not working in Safari 10+ with products that use the Gravity Forms Addons extension Jun 6, 2017

@roykho roykho referenced this issue Jun 29, 2017

Closed

Apple Pay will not work with Product Bundles #302

0 of 2 tasks complete

@roykho roykho changed the title from [Apple Pay] not working in Safari 10+ with products that use the Gravity Forms Addons extension to [Apple Pay] not working with Addons like Gravity forms, product bundles and the like Jun 29, 2017

@roykho roykho referenced this issue Jul 3, 2017

Closed

Apple Pay: Not displaying fees/surcharges... #304

0 of 2 tasks complete
@WillBrubaker

This comment has been minimized.

WillBrubaker commented Jan 23, 2018

FWIW, Measurement Price Calculator probably wants to be included in "the like" as reported in ticket: 894593-zen

@helgatheviking

This comment has been minimized.

helgatheviking commented Jan 29, 2018

Just adding that Mix and Match is in the batch of plugins that don't work with Apple Pay.

@helgatheviking

This comment has been minimized.

helgatheviking commented Jan 30, 2018

What about mimicking the handler approach from core and default to the simple handler?
helgatheviking@c1af73e

If you add a supported_product_types() check that could work. It needs some JS to alter what data is posted via AJAX though, so it's incomplete as is.

@spraveenitpro

This comment has been minimized.

spraveenitpro commented Feb 22, 2018

Created a follow up ticket for this 972225-zen @roykho

@helgatheviking

This comment has been minimized.

helgatheviking commented Feb 28, 2018

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@woocommerce woocommerce deleted a comment from gabrielhuisg Feb 28, 2018

@roykho

This comment has been minimized.

Member

roykho commented Feb 28, 2018

Closed in favor of #566

@roykho roykho closed this Feb 28, 2018

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Feb 28, 2018

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Mar 8, 2018

Hello

May I know where I can make the changes for adding the delivery fields to the post variable when the order is placed with Apple pay.

Thanks

@roykho

This comment has been minimized.

Member

roykho commented Mar 8, 2018

Sorry you need to hire a developer to do that for you. We don't offer that kind of support here.

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Mar 8, 2018

I understand. Currently I am trying to hire a developer. However I would need your help to inform me the areas which I need to change on your plugin because you're any expert in the plugin that you created.

Thanks for your help

@roykho

This comment has been minimized.

Member

roykho commented Mar 8, 2018

The developer you will hire should know how to do it.

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Mar 8, 2018

The developer is unsure at the moment. He was asking for your help on that

@roykho

This comment has been minimized.

Member

roykho commented Mar 8, 2018

Sorry we're unable to help with that.

@gabrielhuisg

This comment has been minimized.

gabrielhuisg commented Mar 8, 2018

Can you at least direct me which part we should make changes? Like are there any areas that we should look it?

@roykho

This comment has been minimized.

Member

roykho commented Mar 8, 2018

Sorry we don't know until we look into it.

@woocommerce woocommerce locked as off topic and limited conversation to collaborators Mar 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.