Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon enhancement request #445

Closed
LaurenaRehbein opened this issue Jan 11, 2018 · 6 comments
Assignees
Milestone

Comments

@LaurenaRehbein
Copy link

@LaurenaRehbein LaurenaRehbein commented Jan 11, 2018

What I expected: Icons to appear in color as they did in the last version. Instead, these are grey.

http://cld.wthms.co/PfvEVI
Full Image: http://cld.wthms.co/PfvEVI+

http://cld.wthms.co/yiGjRE
Full Image: http://cld.wthms.co/yiGjRE+

I understand this is not a bug and documentation is pending, but wanted to note it here after receiving an inquiry.

@roykho

This comment has been minimized.

Copy link
Member

@roykho roykho commented Jan 11, 2018

Because of the addition of many other EU payment methods we can't source each icon from different places. We now use a set that contains all seen here https://paymentfont.com/#icons

These are all scalable which was why we're using it. If there were a complete set that was in color, we would have used that however there weren't.

@LaurenaRehbein

This comment has been minimized.

Copy link
Author

@LaurenaRehbein LaurenaRehbein commented Jan 11, 2018

Thank you for the clarification, Roy! I've updated the requestor.

@douglsmith

This comment has been minimized.

Copy link

@douglsmith douglsmith commented Jan 12, 2018

The icons are all in a font now, which can't contain color.

Unfortunately, other payment gateway plugins are still using color icons. So when used together this makes those others stand out more as if the store is featuring some payment methods as a preferred choice even though that is not the intention.

For example, it's common to use Stripe and PayPal together. Now that the Stripe icons are black and white it looks like we're emphasizing PayPal.

I'm using CSS to make the others I use black and white so it's at least somewhat consistent for the customer.

@LaurenaRehbein

This comment has been minimized.

Copy link
Author

@LaurenaRehbein LaurenaRehbein commented Jan 12, 2018

Thanks to @roykho the documentation has been updated to include a fix for this: https://docs.woocommerce.com/document/stripe/#section-32

I've written it up as a tutorial here: https://laurena.blog/woocommerce-stripe-4-0-icons/

@jranavas

This comment has been minimized.

Copy link

@jranavas jranavas commented Jan 22, 2018

Maybe this payment methods font is good for development, but is very bad to final customer, who sees some icons in colour (other methods) and Stripe in grey.

By default, every option can have a small png image and be required as needed vía <img> tag, like the filter does.

If one concrete method don't have a brand-colored png, we can contact them or search an option.

@roykho roykho added this to the 4.1.0 milestone Feb 22, 2018
@roykho roykho self-assigned this Feb 22, 2018
@roykho

This comment has been minimized.

Copy link
Member

@roykho roykho commented Mar 14, 2018

This is added to 4.1.

@roykho roykho closed this Mar 14, 2018
roykho added a commit that referenced this issue Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.