Skip to content

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Sep 12, 2018

Details:

In this PR we're:

  • Removing the Orders List "Error Overlay" (which was being displayed whenever Sync failed)
  • Implementing a super cool Notice, which will show up on top of the tabBar, and will let users retry the Sync OP.

cc @bummytime @mindgraffiti (Thanks in advance!!!)
Closes #286


Scenario: Placeholder

  1. Fresh install the app
  2. Log into your Woo Store
  3. Open the Orders tab
  4. Verify the Skeleton shows up while the orders are loaded.

Scenario: Empty / Filtered

  1. Check out the latest commit of this PR
  2. Log into your Woo Store
  3. Open the Orders tab
  4. Filter by Order Status (and select a status that has no visible orders)
  5. Verify the Empty State / Filtered UI shows up
  6. Press the Remove Filter button
  7. Verify the unfiltered results show up

Scenario: Empty State / Unfiltered

  1. Check out this commit: ff3772d
  2. Log into your Woo Store
  3. Open the Orders tab
  4. Verify that the Empty State UI shows up.
  5. Press the Action Button
  6. Verify that your Store shows up in a WebView

Scenario: Error Notice

  1. Check out this commit: 3546d24
  2. Log into your Woo Store
  3. Open the Orders tab
  4. Verify the Error State is Onscreen
  5. Press the Retry button
  6. Verify shortly after the error screen shows up again

@mindgraffiti
Copy link
Contributor

mindgraffiti commented Sep 13, 2018

✅ Skeleton placeholder
✅ Empty / filtered
❔ Empty / unfiltered - the main screen is correct, but should the "Unable to refresh" notice be popping up?
share-store copy
✅Error notice

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! First two test items working as expected. Last two are giving unexpected results, see screenshots in main comment.

@mindgraffiti
Copy link
Contributor

mindgraffiti commented Sep 14, 2018

Re-tested. The 3rd test was happening because I have an edge case for a shop.

My edge case shop: hellotesters.blog
Shows an error with the empty store messaging:
edge-case copy

...because that site used to have an active installation of the WooCommerce plugin. I haven't done any updates to the plugin and it's been deactivated (and somehow erased?) from the site.

All that to say, thanks @jleandroperez and :shipit: 💯

Copy link
Contributor

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great @jleandroperez ! :shipit:

@jleandroperez
Copy link
Contributor Author

Thank you both!!!

@jleandroperez jleandroperez merged commit 2b3d6fb into develop Sep 14, 2018
@jleandroperez jleandroperez deleted the issue/286-orders-list-improved-error-handling branch September 14, 2018 14:54
@bummytime bummytime mentioned this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order list Related to the order list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants