Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics Hub] Move the analytics hub see more button out of the Feature flag #8356

Merged
merged 2 commits into from Dec 8, 2022

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Dec 8, 2022

Closes: #8354

Description

This PR removes the see more button from the Feature Flag constraint, making the Analytics Hub effectively available to all of our user base.

The Custom selection range and visitors and views stats are still under development and should be behind the feature flag. However, since both features are still unmerged in the trunk branch, we should expect the flags adjustment to happen in their respective PRs, as suggested in this comment.

Testing instructions

Simply test the Analytics Hub entry point with the disabled feature flag and verify that the Hub is working and showing up as expected.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ThomazFB ThomazFB added the feature: stats Related to stats, including Top Performers. label Dec 8, 2022
@ThomazFB ThomazFB marked this pull request as ready for review December 8, 2022 16:38
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 8, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8356-d52b7ce on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr self-assigned this Dec 8, 2022
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Could we add a release note for this?

I merged trunk into this branch locally for testing (to make sure I had all the latest changes) and everything seems to be working well in my testing. Some things I checked, for reference:

  • Accessibility (VoiceOver, landscape, and dynamic type)
  • iPad experience
  • Data compared to Woo Core Analytics
  • Date ranges (dates shown)

An issue I noticed that I think isn't a blocker for launch: Because we're using the device settings, the week date ranges ("Week to Date" and "Last Week") don't necessarily match what's in Woo Core. That's because Woo Core always uses Sunday as the start of the week, whereas the device settings can start on a different day (e.g. Monday). That said, the Core behavior also isn't ideal (see woocommerce/woocommerce#33595). We might want to eventually consider using the site settings rather than device settings for deciding the calendar and timezone for analytics.

Another followup enhancement we might want to consider is our VoiceOver support on this screen. Right now the data isn't grouped at all, so it isn't clear what labels apply to which data points.

@ThomazFB
Copy link
Contributor Author

ThomazFB commented Dec 8, 2022

Thank you so much @rachelmcr, for dedicating some of your time to do a wide test of the feature! 🙇

Could we add a release note for this?

Yes! 😅 I was supposed to submit the release notes update after opening the PR and forgot 😬 Thanks for the reminder! Fixed here: d52b7ce

We might want to eventually consider using the site settings rather than device settings for deciding the calendar and timezone for analytics.

I agree with your assessment of this. Just for context, originally, we planned to do so through this issue, but we found out that to achieve this, we would have to update other sections of the app to avoid stats differences between the Widget, My Store view and the Hub itself. Now that we're releasing the main part of the feature, maybe we could do a follow-up on this matter.

Another followup enhancement we might want to consider is our VoiceOver support on this screen. Right now the data isn't grouped at all, so it isn't clear what labels apply to which data points.

Good point! I'll open an issue for us to track and address this! Thank you so much!

@ThomazFB ThomazFB merged commit 730c4b4 into trunk Dec 8, 2022
@ThomazFB ThomazFB deleted the issue/8354-adjust-analytics-hub-feature-flag branch December 8, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: stats Related to stats, including Top Performers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Remove the Analytics Hub feature flag from the My Store see more button
3 participants