From 218e45d18b019f19c95135b7f420c010413b3a1f Mon Sep 17 00:00:00 2001 From: Chi-Hsuan Huang Date: Wed, 15 Mar 2023 12:47:33 +0800 Subject: [PATCH] Fix e2e test --- .../js/admin-e2e-tests/changelog/remove-wcpay-accordion | 4 ++++ packages/js/admin-e2e-tests/src/pages/PaymentsSetup.ts | 6 ------ .../tests/e2e-pw/tests/admin-tasks/payment.spec.js | 3 --- 3 files changed, 4 insertions(+), 9 deletions(-) create mode 100644 packages/js/admin-e2e-tests/changelog/remove-wcpay-accordion diff --git a/packages/js/admin-e2e-tests/changelog/remove-wcpay-accordion b/packages/js/admin-e2e-tests/changelog/remove-wcpay-accordion new file mode 100644 index 000000000000..a84afb86acdd --- /dev/null +++ b/packages/js/admin-e2e-tests/changelog/remove-wcpay-accordion @@ -0,0 +1,4 @@ +Significance: patch +Type: update + +Update showOtherPaymentMethods() to test latest payment task properly diff --git a/packages/js/admin-e2e-tests/src/pages/PaymentsSetup.ts b/packages/js/admin-e2e-tests/src/pages/PaymentsSetup.ts index 5454a276cc47..2404ff42000d 100644 --- a/packages/js/admin-e2e-tests/src/pages/PaymentsSetup.ts +++ b/packages/js/admin-e2e-tests/src/pages/PaymentsSetup.ts @@ -31,12 +31,6 @@ export class PaymentsSetup extends BasePage { } async showOtherPaymentMethods(): Promise< void > { - const selector = '.woocommerce-task-payments button.toggle-button'; - await this.page.waitForSelector( selector ); - const toggleButton = await this.page.$( - `${ selector }[aria-expanded=false]` - ); - await toggleButton?.click(); await waitForElementByText( 'h2', 'Offline payment methods' ); } diff --git a/plugins/woocommerce/tests/e2e-pw/tests/admin-tasks/payment.spec.js b/plugins/woocommerce/tests/e2e-pw/tests/admin-tasks/payment.spec.js index 78435a0548be..56052007ec44 100644 --- a/plugins/woocommerce/tests/e2e-pw/tests/admin-tasks/payment.spec.js +++ b/plugins/woocommerce/tests/e2e-pw/tests/admin-tasks/payment.spec.js @@ -113,9 +113,6 @@ test.describe( 'Payment setup task', () => { .catch( () => {} ); await page.waitForLoadState( 'networkidle' ); - // purposely no await again - page.click( 'button.toggle-button' ); - // enable COD payment option await page.click( 'div.woocommerce-task-payment-cod > div.woocommerce-task-payment__footer > button'