diff --git a/plugins/woocommerce-admin/changelogs/fix-woonav-page-refresh b/plugins/woocommerce-admin/changelogs/fix-woonav-page-refresh new file mode 100644 index 000000000000..ce8f65a39e3e --- /dev/null +++ b/plugins/woocommerce-admin/changelogs/fix-woonav-page-refresh @@ -0,0 +1,4 @@ +Significance: patch +Type: Fix + +Fixing an unwanted page refresh when using Woo Navigation diff --git a/plugins/woocommerce-admin/client/layout/index.js b/plugins/woocommerce-admin/client/layout/index.js index 8eadde2d7a77..9e1fdbd5fb3d 100644 --- a/plugins/woocommerce-admin/client/layout/index.js +++ b/plugins/woocommerce-admin/client/layout/index.js @@ -174,6 +174,9 @@ class _Layout extends Component { ) } + { window.wcAdminFeatures.navigation && ( + + ) } ); } diff --git a/plugins/woocommerce-admin/client/layout/navigation.js b/plugins/woocommerce-admin/client/layout/navigation.js index 35e036755edb..73bc6c603439 100644 --- a/plugins/woocommerce-admin/client/layout/navigation.js +++ b/plugins/woocommerce-admin/client/layout/navigation.js @@ -93,4 +93,5 @@ const NavigationPlugin = () => { registerPlugin( 'wc-admin-navigation', { render: NavigationPlugin, + scope: 'woocommerce-navigation', } ); diff --git a/plugins/woocommerce-admin/docs/examples/extensions/add-navigation-items/js/index.js b/plugins/woocommerce-admin/docs/examples/extensions/add-navigation-items/js/index.js index 5bde5df5fcea..561e2ab73798 100644 --- a/plugins/woocommerce-admin/docs/examples/extensions/add-navigation-items/js/index.js +++ b/plugins/woocommerce-admin/docs/examples/extensions/add-navigation-items/js/index.js @@ -3,21 +3,24 @@ */ import { __ } from '@wordpress/i18n'; import { Button } from '@wordpress/components'; -import { registerPlugin } from "@wordpress/plugins"; -import { WooNavigationItem } from "@woocommerce/navigation"; +import { registerPlugin } from '@wordpress/plugins'; +import { WooNavigationItem } from '@woocommerce/navigation'; const MyPlugin = () => { - const handleClick = () => { - alert( 'Menu item clicked!' ); - } + const handleClick = () => { + alert( 'Menu item clicked!' ); + }; - return ( - - - - ); + return ( + + + + ); }; -registerPlugin('my-plugin', { render: MyPlugin }); +registerPlugin( 'my-plugin', { + render: MyPlugin, + scope: 'woocommerce-navigation', +} ); diff --git a/plugins/woocommerce-admin/docs/features/navigation.md b/plugins/woocommerce-admin/docs/features/navigation.md index a307ca23d850..6bb687ed9205 100644 --- a/plugins/woocommerce-admin/docs/features/navigation.md +++ b/plugins/woocommerce-admin/docs/features/navigation.md @@ -121,5 +121,5 @@ const MyPlugin = () => { ); }; -registerPlugin('my-plugin', { render: MyPlugin }); +registerPlugin( 'my-plugin', { render: MyPlugin, scope: 'woocommerce-navigation' } ); ```