From b0d4568a8d973edd60cd79448c8e8207b3e0275f Mon Sep 17 00:00:00 2001 From: Lourens Schep Date: Thu, 13 Apr 2023 13:08:16 +0200 Subject: [PATCH] Fix bug where typed values did not show up --- .../product-category-metabox/category-add-new.tsx | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/plugins/woocommerce-admin/client/wp-admin-scripts/product-category-metabox/category-add-new.tsx b/plugins/woocommerce-admin/client/wp-admin-scripts/product-category-metabox/category-add-new.tsx index 66a212c177e1..b28ef000f426 100644 --- a/plugins/woocommerce-admin/client/wp-admin-scripts/product-category-metabox/category-add-new.tsx +++ b/plugins/woocommerce-admin/client/wp-admin-scripts/product-category-metabox/category-add-new.tsx @@ -23,6 +23,14 @@ declare const wc_product_category_metabox_params: { search_categories_nonce: string; }; +function getCategoryTermLabel( item: CategoryTerm | null ): string { + return item?.name || ''; +} + +function getCategoryTermKey( item: CategoryTerm | null ): string { + return String( item?.term_id ); +} + export const CategoryAddNew: React.FC< { selected: CategoryTerm[]; onChange: ( selected: CategoryTerm[] ) => void; @@ -150,8 +158,8 @@ export const CategoryAddNew: React.FC< { selected={ categoryParent || null } placeholder={ __( 'Find category', 'woocommerce' ) } onSelect={ setCategoryParent } - getItemLabel={ ( item ) => item?.name || '' } - getItemValue={ ( item ) => String( item?.term_id ) } + getItemLabel={ getCategoryTermLabel } + getItemValue={ getCategoryTermKey } onRemove={ () => setCategoryParent( undefined ) } />