From fdca43ddaca147d5a4e5cae871fadd920489d6e4 Mon Sep 17 00:00:00 2001 From: Lourens Schep Date: Mon, 13 Mar 2023 14:21:04 +0100 Subject: [PATCH] Fix lint error and remove unused utils --- .../components/block-editor/block-editor.tsx | 12 +++++---- packages/js/product-editor/src/utils/index.ts | 1 - .../src/utils/parse-product-to-blocks.ts | 22 ---------------- .../src/utils/register-template.tsx | 26 ------------------- 4 files changed, 7 insertions(+), 54 deletions(-) delete mode 100644 packages/js/product-editor/src/utils/parse-product-to-blocks.ts delete mode 100644 packages/js/product-editor/src/utils/register-template.tsx diff --git a/packages/js/product-editor/src/components/block-editor/block-editor.tsx b/packages/js/product-editor/src/components/block-editor/block-editor.tsx index 5d3a11dbb1bba..db5b062a707f0 100644 --- a/packages/js/product-editor/src/components/block-editor/block-editor.tsx +++ b/packages/js/product-editor/src/components/block-editor/block-editor.tsx @@ -5,11 +5,6 @@ import { Template } from '@wordpress/blocks'; import { createElement, useMemo, useLayoutEffect } from '@wordpress/element'; import { Product } from '@woocommerce/data'; import { useSelect, select as WPSelect, useDispatch } from '@wordpress/data'; -import { - // eslint-disable-next-line @typescript-eslint/ban-ts-comment - // @ts-ignore store should be included. - useEntityBlockEditor, -} from '@wordpress/core-data'; import { uploadMedia } from '@wordpress/media-utils'; import { // eslint-disable-next-line @typescript-eslint/ban-ts-comment @@ -27,6 +22,13 @@ import { WritingFlow, ObserveTyping, } from '@wordpress/block-editor'; +// It doesn't seem to notice the External dependency block whn @ts-ignore is added. +// eslint-disable-next-line @woocommerce/dependency-group +import { + // eslint-disable-next-line @typescript-eslint/ban-ts-comment + // @ts-ignore store should be included. + useEntityBlockEditor, +} from '@wordpress/core-data'; /** * Internal dependencies diff --git a/packages/js/product-editor/src/utils/index.ts b/packages/js/product-editor/src/utils/index.ts index b168795ec1df9..b2ddb029f36af 100644 --- a/packages/js/product-editor/src/utils/index.ts +++ b/packages/js/product-editor/src/utils/index.ts @@ -20,7 +20,6 @@ import { preventLeavingProductForm } from './prevent-leaving-product-form'; export * from './create-ordered-children'; export * from './sort-fills-by-order'; export * from './init-blocks'; -export * from './register-template'; export { AUTO_DRAFT_NAME, diff --git a/packages/js/product-editor/src/utils/parse-product-to-blocks.ts b/packages/js/product-editor/src/utils/parse-product-to-blocks.ts deleted file mode 100644 index 145495bbdf45f..0000000000000 --- a/packages/js/product-editor/src/utils/parse-product-to-blocks.ts +++ /dev/null @@ -1,22 +0,0 @@ -/** - * External dependencies - */ -import { Product } from '@woocommerce/data'; -import { BlockInstance, createBlock } from '@wordpress/blocks'; - -/** - * Internal dependencies - */ -import nameBlock from '../components/details-name-block/block.json'; - -export function parseProductToBlocks( product: Partial< Product > ) { - const blocks: BlockInstance[] = []; - - blocks.push( - createBlock( nameBlock.name, { - name: product.name, - } ) - ); - - return blocks; -} diff --git a/packages/js/product-editor/src/utils/register-template.tsx b/packages/js/product-editor/src/utils/register-template.tsx deleted file mode 100644 index 8d75cf4c6368a..0000000000000 --- a/packages/js/product-editor/src/utils/register-template.tsx +++ /dev/null @@ -1,26 +0,0 @@ -/** - * External dependencies - */ -import { createElement } from '@wordpress/element'; -import { registerBlockType, Template } from '@wordpress/blocks'; -import { InnerBlocks } from '@wordpress/block-editor'; -import { Product } from '@woocommerce/data'; - -export const registerTemplate = ( { - template, -}: { - product?: Partial< Product >; - template: Template[] | undefined; -} ) => { - registerBlockType( 'woocommerce/product-template', { - title: 'My Template Block', - category: 'widgets', - attributes: {}, - edit: () => { - return createElement( InnerBlocks, { - template, - templateLock: false, - } ); - }, - } ); -};