New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks CRUD #12439

Closed
claudiosanches opened this Issue Nov 22, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@claudiosanches
Member

claudiosanches commented Nov 22, 2016

Currently webhooks uses shop_webhook post type and webhook_delivery comment type, what is not the ideal, since every time a webhook is triggered a new comment is create.
So we should wrap webhooks into a CRUD and log the deliveries into the new WC_Logger system, and webhooks is a good candidate to be moved to new tables, since there is not too many data to be migrated.

TODO

  • Allow body to be set so it's sent based on the data at the time of the event #15699
  • Add variation triggers too #15198
  • Log duration to generate webhook data #17010

@claudiosanches claudiosanches added this to the 2.8 milestone Nov 22, 2016

@mikejolley mikejolley modified the milestone: 2.8 Nov 23, 2016

@mikejolley mikejolley modified the milestones: 2.8, 2.8 - Sprint #3 Feb 6, 2017

@mikejolley mikejolley modified the milestones: ⚡ 3.1.0: Sprint 3, 3.2.0 Apr 11, 2017

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley May 25, 2017

Member

Todo: Add variation triggers too #15198

Member

mikejolley commented May 25, 2017

Todo: Add variation triggers too #15198

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Jun 27, 2017

Member

Todo: Allow body to be set so it's sent based on the data at the time of the event #15699

Member

mikejolley commented Jun 27, 2017

Todo: Allow body to be set so it's sent based on the data at the time of the event #15699

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Nov 13, 2017

Member

Investigate; webhooks in table, cron to serve from table (periodically).

Member

mikejolley commented Nov 13, 2017

Investigate; webhooks in table, cron to serve from table (periodically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment