Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/checkout/ make <h3> be <h2> in the form #21173

Closed
manake opened this issue Aug 23, 2018 · 4 comments

Comments

@manake
Copy link

commented Aug 23, 2018

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
It's inconsistent with the rest of WordPress when the checkout form doesn't have <h2> tags but it starts with <h3>.

@rianrietveld

This comment has been minimized.

Copy link

commented Aug 24, 2018

+1 for making the heading order semantically right.
But upgrading the H3s to H2s will influence the way the headings are displayed and will have an impact on existing designs and that's not really a good idea IMHO.

One solution could be to add a visually hidden H2 heading above the form, with a title like for example:
<h2 class="screen-reader-text">Your details and order</h2>
The .screen-reader-text class is present in the Woo CSS and will hide an element from vision, but will keep it in the HTML5. That way the heading structure will stay logical for screen reader users and search engines.

@willgorham

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

This will definitely cause backwards compatible styling issues because those headings have no classes - forcing users to style them based on tag.

@manake

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

I know it will.

How about using flags for all such features:
add_theme_support( 'new-improvement' )

And in the next major release the previous version would be removed.

Otherwise it will always stay at <h3> (which is not a bug but it's inconsistent) and more people will come here to report this sooner or later.

I would estimate this to have priority 1/10 but there are other similar things with 10/10 priority (you can find some in my tickets).

@kloon kloon added the enhancement label Aug 27, 2018
@kloon

This comment has been minimized.

Copy link
Member

commented Aug 27, 2018

This is a breaking change and can only be considered for a major release, which the next one will be 4.0.

Thanks for the suggestion and seems there are some interest in this so we will table it for possible inclusion in the next major release.

@kloon kloon closed this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.