Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to help #26842

Closed
zeroo5 opened this issue Jun 22, 2020 · 4 comments · Fixed by #27495
Closed

I want to help #26842

zeroo5 opened this issue Jun 22, 2020 · 4 comments · Fixed by #27495
Labels
priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@zeroo5
Copy link

zeroo5 commented Jun 22, 2020

I am Islam from Egypt and use WooCommerce and I want to amend the special regions of Egypt and they are ready for me. I want you to communicate with me and send a form that I fill in so that you can add the governorates and cities of Egypt

Name : Eslam Ghorab
Email : engeslamghorab10@gmail.com

@juliaamosova
Copy link
Contributor

Hi @zeroo5,

Thanks for opening the issue. In order to make sure that we are on the same page, can you please confirm that you would like regions to be added to Egypt when you, for example, select Egypt as a shipping zone? You want to be able to select actual regions of Egypt instead of the country, correct?

Screen Shot 2020-06-23 at 10 13 18 AM

@juliaamosova juliaamosova added the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Jun 23, 2020
@zeroo5
Copy link
Author

zeroo5 commented Jun 24, 2020 via email

@juliaamosova
Copy link
Contributor

juliaamosova commented Jun 24, 2020

Yes, I want to add the governorates to Egypt and within each governorate
its own cities. I have collected and arranged them, either in Arabic or
English, to be compatible with the Arab community.

@zeroo5 Great! You are welcome to submit a PR if you like. Please note that we use UNICODE CLDR format/standard for adding the region to countries in WooCommerce. Regions should be added in English language. List of regions that can be added for Egypt can be found here:

https://github.com/unicode-org/cldr/blob/release-37/common/subdivisions/en.xml#L1268-L1295

Example PR can be found here: #26728

@juliaamosova juliaamosova added type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Jun 24, 2020
@zeroo5
Copy link
Author

zeroo5 commented Jun 24, 2020 via email

rodrigoprimo added a commit that referenced this issue Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants