Yoast's WordPress SEO 1.4.7 changed some filters that we use #2986

Closed
coenjacobs opened this Issue Apr 18, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

coenjacobs commented Apr 18, 2013

Apparently, the wpseo_metadesc filter is no longer called on paging pages of archives:

So, now I have two hooks: one for /shop/page/..., because Yoast doesn't want meta description on "paged", and another one - for the /shop/ itself, after the 1.4.7 upgrade.

We also use this filter in WC_Query: https://github.com/woothemes/woocommerce/blob/master/classes/class-wc-query.php#L96

Need some more looking into it to see if we need to change anything. Might wanna look into integrating it with WordPress SEO a little better so these hooks are no longer needed.

As reported in a WordPress.org forum thread.

jdevalk commented Apr 18, 2013

Not really sure what the issue is here... Replied on the original thread too.

Contributor

tivnet commented Apr 18, 2013

Here is what I see:

add_action( 'wpseo_head', array( $this, 'metadesc' ), 10 );
is now called after
add_action( 'wp_head', array( $this, 'head' ), 1 );

In verstion 1.4.6
function head()
called
$this->metadesc();

Is that possible that this condition did not fire in 1.4.6 because it was inside the wp_head, and now it's after?

if ( get_query_var( 'paged' ) && get_query_var( 'paged' ) > 1 )
            return;

WC's hook was working in 1.4.6
add_filter( 'wpseo_metadesc', array( $this, 'wpseo_metadesc' ) );
This hook is called only if front page is WC shop.

Contributor

tivnet commented Apr 20, 2013

@jdevalk : just a suggestion, maybe. You have these settings:

Sitewide meta settings
[x] Noindex subpages of archives
If you want to prevent /page/2/ and further of any archive to show up in the search results, enable this.

If that's unchecked, then maybe generate meta description, too?

coenjacobs was assigned Apr 23, 2013

Contributor

coenjacobs commented May 1, 2013

This is not a WooCommerce issue. We might look into adding some more compatibility with WordPress SEO at a later stage, but this is by design in that plugin (and is a good thing, imho).

coenjacobs closed this May 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment