New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes ux #11860

Merged
merged 7 commits into from Sep 8, 2016

Conversation

Projects
None yet
3 participants
@jobthomas
Contributor

jobthomas commented Sep 7, 2016

If taxes are disabled in the “General settings tab”, then the “Tax” tab disappears, and the suffix can no longer be edited, but is still displayed in the store


http://cld.wthms.co/1idx3/16tEcXve

This fix makes sure that the suffix is only displayed if taxes are enabled

jobthomas added some commits Sep 7, 2016

Update UX for disabled taxes
If taxes are disabled in the “General settings tab”, then the “Tax” tab
disappears, and the suffix can no longer be edited, but is still
displayed in the store

This fix makes sure that the suffix is only displayed if taxes are
enabled
@jobthomas

This comment has been minimized.

Contributor

jobthomas commented Sep 7, 2016

jobthomas added some commits Sep 7, 2016

@mattyza

This comment has been minimized.

Member

mattyza commented Sep 7, 2016

LGTM 👍

@mikejolley mikejolley merged commit c96a3ea into woocommerce:master Sep 8, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jobthomas jobthomas deleted the jobthomas:taxes-ux branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment