Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow devs to add 'no-link' class to elements to prevent order view link being triggered on row click #18708
Conversation
mikejolley
added this to the 3.3.1 milestone
Jan 31, 2018
mikejolley
added
the
status: needs review
label
Jan 31, 2018
mikejolley
referenced this pull request
Jan 31, 2018
Closed
Remove / disable row onClick event on the orders table in the backend #18704
claudiulodro
added
status: approved
and removed
status: needs review
labels
Jan 31, 2018
This comment has been minimized.
This comment has been minimized.
Works great. Just needs merge conflicts resolved. |
rodrigoprimo
self-requested a review
Jan 31, 2018
rodrigoprimo
requested changes
Jan 31, 2018
I can confirm that if the class woocommerce/assets/css/admin.scss Line 2048 in 1c57075 |
rodrigoprimo
added
status: needs feedback
and removed
status: approved
labels
Jan 31, 2018
This comment has been minimized.
This comment has been minimized.
@rodrigoprimo how did you add it to the TR? The intention was for this to be added to new elements within the cells. |
This comment has been minimized.
This comment has been minimized.
@mikejolley I used the following code (not production ready as it is missing an if statement to add the class only in the order list page):
I thought the intention was to allow devs to prevent order view link being triggered on the whole row and not just on new elements and that is why I tested adding the class to the |
mikejolley
added some commits
Jan 31, 2018
mikejolley
added
status: needs review
and removed
status: needs feedback
labels
Jan 31, 2018
rodrigoprimo
approved these changes
Jan 31, 2018
rodrigoprimo
added
status: approved
and removed
status: needs review
labels
Jan 31, 2018
claudiulodro
merged commit 664aa28
into
master
Jan 31, 2018
1 check passed
claudiulodro
deleted the
fix/18704
branch
Jan 31, 2018
mikejolley
added
the
cherry picked
label
Jan 31, 2018
This comment has been minimized.
This comment has been minimized.
jranavas
commented
Feb 1, 2018
This comment has been minimized.
This comment has been minimized.
The preview modal can be copy pasted. That has the important stuff. |
This comment has been minimized.
This comment has been minimized.
You can add the |
This comment has been minimized.
This comment has been minimized.
This is great. That way we can target only some TD or the entire TR. |
This comment has been minimized.
This comment has been minimized.
jranavas
commented
Feb 3, 2018
•
I found the way to add the "no-link", maybe is useful to others. I hope this is the right way, thanks!
|
This comment has been minimized.
This comment has been minimized.
I don't think you need to check for "manage_woocommerce".
|
This comment has been minimized.
This comment has been minimized.
esaulfarfan
commented
Oct 18, 2018
Thanks @jranavas :) |
mikejolley commentedJan 31, 2018
Closes #18704