Join GitHub today
Humanize emails #21288
Changes proposed in this Pull Request:
This PR updates the copy of all the emails to make it more human and inviting to store admins and customers.
How to test the changes in this Pull Request:
@@ Coverage Diff @@ ## master #21288 +/- ## ============================================ + Coverage 38.51% 39.73% +1.22% - Complexity 13331 13866 +535 ============================================ Files 349 370 +21 Lines 50361 52823 +2462 ============================================ + Hits 19395 20987 +1592 - Misses 30966 31836 +870
Order On-Hold - http://cld.wthms.co/KVA8zZ
Overall these phrasing changes look good, and I don't notice any code issues. Just a couple questions/feedback around some of them. We can address them after beta is tagged if time does not permit this week.
Please can you apply the following changes, then generate another batch of previews for me to do a final proof-read (and run by a second pair of eyes):
Checking: my understanding is that this triggers once payment has been received? If so:
One final thing: unsure about where there should be #'s in front of order number if the table if we don't add it to the subject lines etc? Probably should be consistent there, but I don't have strong feelings either way.
Screenshot after implementing the latest updates as requested:
Admin New Order - http://cld.wthms.co/XxlCAt Ignore the SPAM in the subject
Order On-Hold - http://cld.wthms.co/TLsSjO